gemmellr commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r773741230
##########
File path: artemis-core-client/pom.xml
##########
@@ -86,11 +86,23 @@
<version>${hamcrest.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport-native-unix-common</artifactId>
Review comment:
Isnt this one only a transitive dependency? Feels a bit odd to list it
specifically here given that.
##########
File path: artemis-distribution/pom.xml
##########
@@ -286,6 +286,10 @@
<groupId>io.netty</groupId>
<artifactId>netty-resolver</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport-native-unix-common</artifactId>
Review comment:
Ditto about transitive.
##########
File path: artemis-distribution/src/main/assembly/dep.xml
##########
@@ -86,6 +86,7 @@
<include>io.netty:netty-codec-socks</include>
<include>io.netty:netty-common</include>
<include>io.netty:netty-resolver</include>
+ <include>io.netty:netty-transport-native-unix-common</include>
Review comment:
This include not being present was presumably the main issue since the
other includes cut off the transitive dep (might also have had to turn on
transitive filtering here, so the include actually applied to it...I guess
thats perhaps why you saw need to add the transitive dep to the pom?)
##########
File path: artemis-server/pom.xml
##########
@@ -126,6 +126,10 @@
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport-native-unix-common</artifactId>
Review comment:
Ditto about transitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
