gemmellr commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r783095636
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -443,6 +443,14 @@ public ActiveMQThreadFactory run() {
logger.debug("Acceptor using native kqueue");
} else {
+ if (useEpoll) {
+ ActiveMQServerLogger.LOGGER.nettyEpollNotAvailable(name);
+ }
+
+ if (useKQueue) {
+ ActiveMQServerLogger.LOGGER.nettyKQueueNotAvailable(name);
+ }
Review comment:
Its true by default and is configured true again in the broker.xml by
default, so a bunch of folks will have that explicitly set already. If its
going to be a warning you will have to do all the brittle platform checks as
well, which per other comment there are still cases that still wont be
sufficient and a warning will be emitted in cases its expected not to work.
I really dont think it should be logging a warning for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
