gemmellr commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r782236488
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
##########
@@ -526,6 +526,14 @@ public synchronized void start() {
channelClazz = KQueueSocketChannel.class;
logger.debug("Connector " + this + " using native kqueue");
} else {
+ if (useEpoll) {
+ ActiveMQClientLogger.LOGGER.nettyEpollNotAvailable(this);
+ }
+
+ if (useKQueue) {
+ ActiveMQClientLogger.LOGGER.nettyKQueueNotAvailable(this);
+ }
+
Review comment:
Even with the environment asserted, there are cases in actual use that
its not going to be available by expectation and so such a log is going to be
wrong/misleading. I would simply log what is actually in use (which is already
done, at debug), not try and special case warnings. Simpler, and never wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
