ryan-highley commented on code in PR #4122: URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911477101
########## artemis-server/src/test/resources/ConfigurationTest-xinclude-config-address-settings.xml: ########## @@ -14,7 +14,10 @@ See the License for the specific language governing permissions and limitations under the License. --> -<address-settings xmlns="urn:activemq:core"> +<address-settings xmlns="urn:activemq:core" Review Comment: Reverted all changes to the prior ConfigurationFile-xinclude-....xml unit test resource files. Added a separate unit test class and many modular include files for all top-level, non-trivial element types while still passing the existing FileConfigurationTest and ConfigurationImplTest scenarios. The ConfigurationImplTest#testSerialize() method makes a questionable assumption regarding broker plugins in test configurations but I worked around it to preserve the existing unit test while also including a modular broker plugins file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
