michaelandrepearce commented on code in PR #4122: URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911387589
########## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ########## @@ -16,18 +16,23 @@ limitations under the License. --> <xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"; + xmlns:xi="http://www.w3.org/2001/XInclude"; xmlns="urn:activemq:core" targetNamespace="urn:activemq:core" attributeFormDefault="unqualified" elementFormDefault="qualified" version="1.0"> <xsd:import namespace="http://www.w3.org/XML/1998/namespace"; schemaLocation="xml.xsd"/> + <xsd:import namespace="http://www.w3.org/2001/XInclude"; schemaLocation="XInclude.xsd"/> Review Comment: should we lower case this case this for consistency with the existing xml.xsd (and other xsd files) e.g. xinclude.xsd, also avoids future fun with file case sensitivity we've seen on some systems -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
