ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911250825


##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -16,18 +16,23 @@
   limitations under the License.

Review Comment:
   If you would like me to replicate the original test files with an alternate 
modular include unit test scenario, I will do so. All the original test files 
work unaltered with the updated schema definition, as evidenced by the 
broker-connection and security-settings files. The existing config changes were 
to avoid creating a separate unit test class, which I will now create and 
submit.
   
   The attached screenshot shows one example of the IDE syntax support these 
schema definition changes enable when developing individual modular files, not 
just broker.xml files.
   
   
![XSDIncludeSyntaxSupport](https://user-images.githubusercontent.com/21245081/176733040-16ac65e0-b111-4937-9bff-9600289f4895.png)
   
   I would welcome other input here as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to