clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1152053054
##########
tests/leak-tests/pom.xml:
##########
@@ -246,7 +246,8 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<skipTests>${skipLeakTests}</skipTests>
-
<argLine>-agentpath:${project.basedir}/target/lib/${check-leak-deploy-name}
-Djgroups.bind_addr=::1 ${activemq-surefire-argline}
-Dorg.apache.activemq.SERIALIZABLE_PACKAGES="java.lang,javax.security,java.util,org.apache.activemq,org.fusesource.hawtbuf"</argLine>
+ <!-- -DARTEMIS_DEBUG_REF is needed for RefCountMessageLeakTest
-->
+
<argLine>-agentpath:${project.basedir}/target/lib/${check-leak-deploy-name}
-DARTEMIS_DEBUG_REF=true -Djgroups.bind_addr=::1 ${activemq-surefire-argline}
-Dorg.apache.activemq.SERIALIZABLE_PACKAGES="java.lang,javax.security,java.util,org.apache.activemq,org.fusesource.hawtbuf"</argLine>
Review Comment:
@gemmellr separate config is an overkill on this... there should be only one
test validating for large message.
I didn't want to have a volatile configuration (meaning I could enable it
just for the test), but I may have to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
