gemmellr commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1152063360


##########
tests/leak-tests/pom.xml:
##########
@@ -246,7 +246,8 @@
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
                <skipTests>${skipLeakTests}</skipTests>
-               
<argLine>-agentpath:${project.basedir}/target/lib/${check-leak-deploy-name} 
-Djgroups.bind_addr=::1 ${activemq-surefire-argline} 
-Dorg.apache.activemq.SERIALIZABLE_PACKAGES="java.lang,javax.security,java.util,org.apache.activemq,org.fusesource.hawtbuf"</argLine>
+               <!-- -DARTEMIS_DEBUG_REF is needed for RefCountMessageLeakTest 
-->
+               
<argLine>-agentpath:${project.basedir}/target/lib/${check-leak-deploy-name} 
-DARTEMIS_DEBUG_REF=true -Djgroups.bind_addr=::1 ${activemq-surefire-argline} 
-Dorg.apache.activemq.SERIALIZABLE_PACKAGES="java.lang,javax.security,java.util,org.apache.activemq,org.fusesource.hawtbuf"</argLine>

Review Comment:
   I didnt think a variable config was needed, hence the simpler suggestion. 
You could always fork in the test, I know others do that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to