clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1152303303
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessage.java:
##########
@@ -49,6 +93,28 @@ public int getDurableCount() {
return DURABLE_REF_COUNT_UPDATER.get(this);
}
+ /** Sub classes may mark fired=true when they were explicitly called.
+ * E.g large message removed the file upon cancellation */
+ protected void markFired() {
+ fired = true;
Review Comment:
The first variable is used to control the releaseResources...
The second variable is used to control if the resource leaked or not.
I'm renaming it to leaked.
and I can't read anything from RefCountMessage coming from
RefCountDebugState (I just renamed it BTW).
Having a reference back to RefCountMessage would make it impossible to
release the reference. and I don't want to complicate things with a
WeakReference... I would rather duplicate the variable... in this case I
renamed it to leaked to make a distinction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
