naude-r commented on code in PR #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487#discussion_r1205610027
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/ActiveMQMetricsPlugin.java:
##########
@@ -26,4 +26,10 @@ public interface ActiveMQMetricsPlugin extends Serializable {
ActiveMQMetricsPlugin init(Map<String, String> options);
MeterRegistry getRegistry();
+
+ /**
+ * Allow additional binders to be bound at the right time
+ */
+ default void bind() {
Review Comment:
sure. we have a timing issue in that ActiveMQMetricsPlugin::init is called
before MetricsManager have had the chance to add the common tags.
any metrics created / registered before then will not have the "broker" tag.
not sure there is an easy way to do that without breaking existing plugins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
