naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1563857150
consider the following two metrics as scraped by prometheus:
```
artemis_address_size{address="ExpiryQueue",broker="$FQDN",endpoint="metrics-port",instance="$IP:8161",job="artemis",namespace="infra",service="artemis-exporters"}
jvm_info{endpoint="metrics-port",instance="$IP:8161",job="artemis",namespace="infra",runtime="OpenJDK
Runtime Environment",service="artemis-exporters",vendor="Red Hat,
Inc.",version="17.0.5+8-LTS"}
```
the only way to link the two metrics are the "instance" tag, which in our
case is a raw ip (broker running external to k8s and k8s endpoints only
supports ip addresses). the "broker" contains a user friendly name which make
the dashboard easier to use.
in my opinion there is no way that adding a "broker" tag can break any
existing dashboards and/or expectation. the cardinality will also not increase
since the same broker tag/value pair is already available from the address
metrics.
hope that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
