jbertram commented on code in PR #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487#discussion_r1205828147
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/ActiveMQMetricsPlugin.java:
##########
@@ -26,4 +26,10 @@ public interface ActiveMQMetricsPlugin extends Serializable {
ActiveMQMetricsPlugin init(Map<String, String> options);
MeterRegistry getRegistry();
+
+ /**
+ * Allow additional binders to be bound at the right time
+ */
+ default void bind() {
Review Comment:
In my opinion the broker should simply support the processor and uptime
metrics just like it does the JVM and Netty metrics. That way _every_ user
could benefit from them and the plugin interface wouldn't need to change. I
created https://issues.apache.org/jira/browse/ARTEMIS-4292 for this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
