naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1569907193
> > Yes, that makes sense. Before I merge it can you add a test to ensure
that the {{broker}} tag is set on the JVM & Netty metrics as expected? You
could modify
{{org.apache.activemq.artemis.tests.integration.plugin.JvmMetricsTest}} for the
JVM metrics. However, we don't have an existing test for the Netty metrics so
you could copy the aforementioned {{JvmMetricsTest}} and modify it for the
Netty use-case.
> > To be clear, just about every commit needs a test to validate the change
is working as expected and to mitigate against future regressions.
>
> certainly. will get to it either today or tomorrow.
test cases added as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
