gtully commented on code in PR #4659:
URL: https://github.com/apache/activemq-artemis/pull/4659#discussion_r1395756119
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -517,7 +517,6 @@ public void removeRolledback(MessageReference
messageReference) {
}
public void addRolledback(MessageReference messageReference) {
- currentWindow.decrementAndGet();
Review Comment:
Thanks. There was something weird, but messages going to the DLQ was part of
it.
The other part is the returnReferences that puts messages back in delivering
rather than back on the queue on a tx rollback. With the core session in play,
that also had prefetched messages in the tx, and that was breaking the
returnReferenced logic and causing to many decrements on the currentWindow.
Thanks for picking up on that change :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
