gtully commented on code in PR #4659:
URL: https://github.com/apache/activemq-artemis/pull/4659#discussion_r1395759813
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -517,7 +517,6 @@ public void removeRolledback(MessageReference
messageReference) {
}
public void addRolledback(MessageReference messageReference) {
- currentWindow.decrementAndGet();
Review Comment:
I played with doing the session cancelRef in a new transaction, but multiple
transactions can interact with IO and become out of sync due to any operation
context task clearing the current context. When the delivery count is
persisted, there is IO. That was to root cause of the original investigation,
so I don't want to introduce that possibility again. I think what i have now is
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
