jbertram commented on PR #4681: URL: https://github.com/apache/activemq-artemis/pull/4681#issuecomment-1905221467
This is an interesting improvement which I think has some merit. However, I have two concerns: - This changes the default behavior of every divert. This may break existing users who actually depend on the current behavior. Therefore, this functionality should be configurable. - This will have a negative impact on performance. _Every_ time a message is diverted `checkAutoCreate` will be invoked with a new `QueueConfiguration`. This will increase CPU utilization and GC pressure. Perhaps the divert could invoke `checkAutoCreate` once when it was deployed and then also during the execution of `route` if and only if a transformer was invoked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
