clebertsuconic commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524154424
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1679,7 +1699,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
+ BufferHelper.sizeOfNullableInteger(prefetchPageMessages) +
+ BufferHelper.sizeOfNullableBoolean(autoCreateDivertDestination);
Review Comment:
I'm not sure this is needed any longer... we are not changing the wires for
the old methods.
Preetty much just use JSON for anything new now.. older stuff should stay as
is.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1601,6 +1617,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
if (buffer.readableBytes() > 0) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+
+ if (buffer.readableBytes() > 0) {
Review Comment:
I don't think we should change these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
