AntonRoskvist commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524585315
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1835,6 +1856,8 @@ public void encode(ActiveMQBuffer buffer) {
BufferHelper.writeNullableInteger(buffer, prefetchPageBytes);
BufferHelper.writeNullableInteger(buffer, prefetchPageMessages);
+
+ BufferHelper.writeNullableBoolean(buffer, autoCreateDivertDestination);
Review Comment:
@clebertsuconic Thanks, I have made the changes you suggested. The only
thing I'm noticing now is that if I inject this setting in some current
persistence tests they start failing, though I guess that might be expected
with this new method?
One example of a test that would fail is for instance:
`org.apache.activemq.artemis.tests.integration.persistence.AddressSettingsConfigurationStorageTest#testStoreSecuritySettings()`
where if I add some random previous address setting (like
`setAutoDeleteAddresses(true)`) the test still passes, whereas if I add
`setAutoCreateDivertDestination(true)` the test fails.
Is that right/expected or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
