clebertsuconic commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524997952
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1835,6 +1856,8 @@ public void encode(ActiveMQBuffer buffer) {
BufferHelper.writeNullableInteger(buffer, prefetchPageBytes);
BufferHelper.writeNullableInteger(buffer, prefetchPageMessages);
+
+ BufferHelper.writeNullableBoolean(buffer, autoCreateDivertDestination);
Review Comment:
@AntonRoskvist Can you add your change and rebase your PR on top of
https://github.com/apache/activemq-artemis/pull/4854
The tests were still using the old method. I am removing *any* usage from
the AddressSettings usage, and I am now making it *clearer* with a big javadoc
to not have any more additions.
The reason that you needed to add a field now was a reason I added the JSON
format. I got tired to see that method's wire being changed over time. That
got even worse when I played with my private branches when I was only bringing
the newer field and not the previous field.
So, if I added field A and B on apache/master
and only Brough field B to a private branch, my wire would be inconsistent
with apache/main. It was being clusterFreak to manage it :)
If you could bring my commit to your PR (Rebase as I said), and bring any
changes you like, it should now work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
