tabish121 commented on code in PR #4938:
URL: https://github.com/apache/activemq-artemis/pull/4938#discussion_r1603701586


##########
docs/user-manual/federation-address.adoc:
##########
@@ -112,96 +111,97 @@ Sample Address Federation setup:
 </federations>
 ----
 
-In the above setup downstream broker `eu-north-1` is configured to connect to 
two upstream brokers `eu-east-1` and `eu-east-2`, the credentials used for both 
connections to both brokers in this sample are shared, you can set user and 
password at the upstream level should they be different per upstream.
+In the above setup, downstream broker `eu-north-1` is configured to connect to 
two upstream brokers `eu-east-1` and `eu-west-1`. Credentials used for both 
connections to brokers in this sample are shared.
+Should they be different per upstream, you can alter credentials at the 
upstream level.
 
-Both upstreams are configured with the same address-policy 
`news-address-federation`, that is selecting addresses which match any of the 
include criteria, but will exclude anything that starts `queue.news.sport`.
+Both upstreams are configured with the same address-policy 
`news-address-federation`, that is selecting addresses which match any of the 
include criteria and exclude anything that starts `queue.news.sport`.
 
 *It is important that federation name is globally unique.*
 
-Let's take a look at all the `address-policy` parameters in turn, in order of 
priority.
+==== Priority ordered address-policy parameters
 
 name::
 All address-policies must have a unique name in the server.
+
 include::
-The address-match pattern to include addresses.
-Multiple of these can be set.
-If none are set all addresses are matched.
+The address-match pattern to include addresses. Multiple of these can be set. 
If none are set all addresses are matched.
+
 exclude::
-The address-match pattern to exclude addresses.
-Multiple of these can be set.
+The address-match pattern to exclude addresses. Multiple of these can be set.
+
 max-hops::
-The number of hops that a message can have made for it to be federated, see 
<<topology-patterns,Topology Patterns>> above for more details.
+The number of maximum hops that message can perform across federated 
addresses. See <<topology-patterns,Topology Patterns>> above for details.

Review Comment:
   "The maximum number of hops..."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to