michalxo commented on code in PR #4938: URL: https://github.com/apache/activemq-artemis/pull/4938#discussion_r1604757011
########## docs/user-manual/federation-address.adoc: ########## @@ -112,96 +111,97 @@ Sample Address Federation setup: </federations> ---- -In the above setup downstream broker `eu-north-1` is configured to connect to two upstream brokers `eu-east-1` and `eu-east-2`, the credentials used for both connections to both brokers in this sample are shared, you can set user and password at the upstream level should they be different per upstream. +In the above setup, downstream broker `eu-north-1` is configured to connect to two upstream brokers `eu-east-1` and `eu-west-1`. Credentials used for both connections to brokers in this sample are shared. +Should they be different per upstream, you can alter credentials at the upstream level. -Both upstreams are configured with the same address-policy `news-address-federation`, that is selecting addresses which match any of the include criteria, but will exclude anything that starts `queue.news.sport`. +Both upstreams are configured with the same address-policy `news-address-federation`, that is selecting addresses which match any of the include criteria and exclude anything that starts `queue.news.sport`. *It is important that federation name is globally unique.* -Let's take a look at all the `address-policy` parameters in turn, in order of priority. +==== Priority ordered address-policy parameters Review Comment: Agree with you. I will remove that priority order. Neither I like it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
