iiliev2 commented on code in PR #4899:
URL: https://github.com/apache/activemq-artemis/pull/4899#discussion_r1631317798
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##########
@@ -421,6 +434,34 @@ private void doBufferReceived(final Packet packet) {
}
}
+ private boolean isCorrectPing(Packet packet) {
+ if (packet.getType() != PING) {
+ return true;
Review Comment:
Commenting this line out will effectively disable the fix. This will cause
the new test `ZeroPersistenceSymmetricalClusterTest` to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
