iiliev2 commented on PR #4899:
URL:
https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2301713891
> Is this the kind of message ... you were referring to in the Jira
No, `MessageFlowRecordImpl` becoming bad means that the peer broker holds on
to an instance of it which should have been discarded. We have a workaround
hack in our code which detects when a peer broker is down or its identity
changed, and forces the local broker to evict its message flow record for it.
Something like
```java
this.removeMemberMethod = Topology
.class
.getDeclaredMethod("removeMember", long.class,
String.class, boolean.class);
this.removeMemberMethod.setAccessible(true);
...
removeMemberMethod.invoke(topology, topologyMember.getUniqueEventID() +
1000, topologyMemberId);
```
> I reproduced this with a very simple manual test
I assume you mean you reproduced the WARN message. This is not what we are
trying to fix.
> I would recommend for you ... to use `0 reconnect-attempts` ... given the
fact that persistence is disabled
We were already running that earlier. That resulted in other bugs with the
topology. Can't remember exact details anymore(was a couple of years ago), but
sometimes when a peer came back after the reconnect attempts stopped, it would
no longer be re-admitted in the cluster.
We don't want to go back to a tried configuration which we know didn't work.
> I added your test to the branch with my fix ... but the test still fails
Do you mean it is a false negative(test failed but shouldn't have)? How do
you verify that the topology recovers correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
