iiliev2 commented on PR #4899: URL: https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2298378613
>java.lang.NullPointerException: Cannot invoke "java.util.concurrent.ScheduledExecutorService.scheduleAtFixedRate(java.lang.Runnable, long, long, java.util.concurrent.TimeUnit)" because "this.s" is null I had to update the test to work with JUnit 5(I didn't notice on my last rebase that Artemis upgraded from an earlier JUnit). >Also, I put together a proof-of-concept fix I am having trouble running the multicast discovery tests on my mac. I setup my routes as described in https://issues.apache.org/jira/browse/ARTEMIS-2341 (like last time and that was sufficient to make multicast discovery work). I also added `-Djava.net.preferIPv4Stack=true` to the broker stratup commands, but still I am getting `Can't assign requested address` error(even in other tests like `DiscoveryTest`). So as it stands I am unable to verify if your fix works. I was only able to look at the code, and as far as I can tell, my concerns remain same as I mentioned [earlier](https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2078890094). However, if your fix works reliably, I have no objections. Could you please pull the latest version of test `ZeroPersistenceSymmetricalClusterTest` and run it against your fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
