cshannon commented on PR #1284: URL: https://github.com/apache/activemq/pull/1284#issuecomment-2302718069
I don't think my branch trying to use the JDK will necessarily work based on what @tabish121 pointed out for encoding, and on the decoding side there seems to be issues with compatibility. (probably the same problem seen with the Stomp conversion) @azotcsit - can you explain a bit about your changes and how they were in terms of compatibility with things encoded with the existing/old encoder? Specifically for 4-byte unicode because i'm sure it works fine with 3 byte. This will probably need some tests written to demonstrate the compatibility as well. I tried testing writing a string with 4 byte unicode (the same one in the unit test in this PR) with the old/existing encoder and then decoding it using the JDK UTF-8 decoder in my branch and it breaks. What's interesting is things decode fine with the modified method in this PR to decode. What's even more interesting to me is that even though the existnig code is only supposed to handle 3 byte unicode, i tried testing writing/reading the 4 byte unicode string and it worked (which I guess there's a bug or some other special handling in the custom code) So I'm curious what the big differences are between the JDK version and the modified version in this PR. It's critical to make sure things will be able communicate across versions if sending 4 byte unicode. For example, any old messages in a data store would need to be able to be decoded still after upgrade and another example could be old clients with the old encoding logic sending messages with 4 byte unicode to a broker that has been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
