cshannon commented on PR #1284: URL: https://github.com/apache/activemq/pull/1284#issuecomment-2313728021
@mattrpav - I think something like that with OpenWire may work but still need to figure out the exact details. I checked the CPP andNMS clients and they have the same logic/bug, so another advantage of tying the fix to a new OpenWire version is those clients will not break since we would keep the existing broken logic for old openwire. https://github.com/apache/activemq-cpp/blob/d6f76ede90d21b7ee2f0b5d4648e440e66d63003/activemq-cpp/src/main/decaf/io/DataOutputStream.cpp#L272-L339 https://github.com/apache/activemq-nms-api/blob/93eacbe7a258518cd5f12642c62d28aed0d6d1bc/src/nms-api/Util/EndianBinaryWriter.cs#L200 Something else as I was looking at openwire that looks fishy and may suffer the same issue is this: https://github.com/apache/activemq/blob/e45ee4aae5b49986750d5a2feb171f36cf432fca/activemq-client/src/main/java/org/apache/activemq/openwire/v12/BaseDataStreamMarshaller.java#L308-L342 So we may need to fix the marshallers. There's also the issue that we need to use the new OpenWire project as the current generation doesn't work unless you use JDK 8 and 5.x version (which we could do and cherry pick). The new OpenWire project may not be quite ready yet and also has common marshalling code for all versions so that might be a problem if we fix the bug in BaseDataStreamMarshaller in that project for the old versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
