mattrpav commented on PR #1284: URL: https://github.com/apache/activemq/pull/1284#issuecomment-2313740187
@cshannon good catch on the tight marshaller. Moving the encoding logic to a UTF8Util or similar probably a good step to catch these locations and centralize. We could then include the legacy handling as an overload method. Draft steps: 1. Create new OpenWire version with support for full length utf8 strings 2. Update existing OpenWire code generation out-of-tree using JDK 8 and ActiveMQ 5 3. Update WireFormat to support the optional flag to perform legacy utf8 handling Documentation notes: For applications that need old and new handling with the new OpenWire version in the same broker, they would need to configure separate transport connectors. One with the legacy utf8 encoding configured via wireformat config flag and another one that supports the new option. Older OpenWire versions just 'get' the old utf8 string handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
