iiliev2 commented on PR #4899: URL: https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2303007461
> For example, if your use-case required messages to survive a broker restart then setting persistence-enabled to false would be technically possible, but it would not be valid. Yes, however that (may) be a recovarable situation - to just fix our configuration. In this case however, there is no recovering(unless we resort to hacks), no matter which configuration we use. Running inside k8s is not the only use case we want to support. We also deploy in other modes, where nodes do keep identities between restarts. There can be all kinds of variations to the deployment. We need a single configuration that works in all cases, not multiple different ones, each of which is prone to various bugs(as history has proven). We would never get anything resolved that way. We have communicated before we even started to work on this fix. The approach via the `Ping` packets has been validated with you. There are plenty of tests to guarantee the robustness of these changes. Why would effectively 2 additional longs in one kind of (management) message be that big of a performance hit(if that is your concern here)? How can we profile this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
