clebertsuconic commented on code in PR #5346:
URL: https://github.com/apache/activemq-artemis/pull/5346#discussion_r1842665520
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java:
##########
@@ -346,6 +346,7 @@ public void onMessageComplete(Delivery delivery,
connection.requireInHandler();
try {
+ this.messageReader.close();
Review Comment:
@gemmellr leaving the close to happen after the advance would allow a
situation where we confirm the client the message has been accepted. Later the
server crashed, even after a commit (depending on how fast it happened) and the
file wasn't yet closed.. leaving a truncated file in the file system...
After a restart the file still zeroed because the buffer that contained the
file before the close is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
