clebertsuconic commented on code in PR #5346:
URL: https://github.com/apache/activemq-artemis/pull/5346#discussion_r1842677516
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java:
##########
@@ -346,6 +346,7 @@ public void onMessageComplete(Delivery delivery,
connection.requireInHandler();
try {
+ this.messageReader.close();
Review Comment:
just to bring the commit closer to this discussion: the test started to
faill after c83ed8957d9d7f06bb29c0fce563fe2e3462993e
a change ont he producer side (and the only that could affect the large
message generation from what I looked) was moving this .close to the finalize...
I thought I knew why... but I now don't know why it works after this line
reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
