tabish121 commented on code in PR #5346:
URL: https://github.com/apache/activemq-artemis/pull/5346#discussion_r1842675735
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java:
##########
@@ -346,6 +346,7 @@ public void onMessageComplete(Delivery delivery,
connection.requireInHandler();
try {
+ this.messageReader.close();
Review Comment:
That doesn't make a ton of sense though as the onMessageCompleted is called
only after the large message release resources has been called meaning the
large message file in LargeBodyImpl should have already been "closed" unless
you mean something other than closed when you are saying closed. Also the
close in the try / finally block is a fail safe to ensure that if an error
occurs on that path then things actually do get closed, which again should have
already been done. We need a bit more detail on this as currently it simply
doesn't seem right as I'd have expected that close call to be a no-op as
AMQPLargeMessageReader would check state of 'currentMessage' and see that it
was already null as it is nulled before onMessageCompleted is ever called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
