gemmellr commented on code in PR #5363:
URL: https://github.com/apache/activemq-artemis/pull/5363#discussion_r1851947858
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
// set common address settings needed for all tests; make sure to use
getMatch instead of addMatch in invidual tests or these will be overwritten
server.getAddressSettingsRepository().addMatch("#", new
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress),
new AddressSettings().setExpiryDelay(-1L));
Review Comment:
I'm actually curious why it is setting expiry delay on the regular address
settings to begin with, and whether that call should go away instead of adding
this?
Most of the tests look to send messages that have expiration and are
already-expired, so the setting shouldnt affect them after this change.
The exceptions seem to be testAutoCreatedExpiryFilterAnycast /
testAutoCreatedExpiryFilterMulticast that seem to send messages without
expiration. Could it just change to setting one, and then remove the
ExpiryDelay setting here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
