clebertsuconic commented on code in PR #5363:
URL: https://github.com/apache/activemq-artemis/pull/5363#discussion_r1852284956


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
 
       // set common address settings needed for all tests; make sure to use 
getMatch instead of addMatch in invidual tests or these will be overwritten
       server.getAddressSettingsRepository().addMatch("#", new 
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+      
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress), 
new AddressSettings().setExpiryDelay(-1L));

Review Comment:
   other tests are failing in the same situation if I don't set this..
   
   
   I had added more loops and more sleeps to other tests and they also failed.
   
   
   I would rather keep this instead of  rewrite this test.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to