gemmellr commented on code in PR #5363:
URL: https://github.com/apache/activemq-artemis/pull/5363#discussion_r1852311112
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
// set common address settings needed for all tests; make sure to use
getMatch instead of addMatch in invidual tests or these will be overwritten
server.getAddressSettingsRepository().addMatch("#", new
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress),
new AddressSettings().setExpiryDelay(-1L));
Review Comment:
Fair enough, you had only mentioned the FQQN one so I thought it was the
only one actually needing this (which is why I didnt like changing it for all
tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
