cshannon commented on PR #1364: URL: https://github.com/apache/activemq/pull/1364#issuecomment-2532189918
I need to look more into it later when I have more time but I started looking at the spec details and also the previous comments of concerns to try and figure out what the issues are. There's a few things but it looked like one of the biggest concerns was whether or not the ordering requirements are being met. The PR mentions that ordering is handled by the broker so I was trying to figure out if it's true for all the cases we need to care about. Specifically, things like persistent vs non-persistent messages being intermixed and also anonymous producers across destinations, etc. Looking at the spec in detail, I think the current async behavior might be good enough but not sure yet. It says the async behavior must follow the sync and is described at: https://jakarta.ee/specifications/messaging/3.1/jakarta-messaging-spec-3.1#order-of-message-sends. Specifically I noticed it says: 1. The spec talks about ordering only being guaranteed for the same delivery mode (persistent or non persistent) so we may be ok: ` If both PERSISTENT and NON_PERSISTENT messages are sent to a destination, order is only guaranteed within delivery mode.` 2. The spec mentions `The only ordering that is visible to receiving clients is the order of messages a session sends to a particular destination. `so I think as long as we can make sure the broker/client guarantee the ordering per destination it might be ok as well. All of this needs to be looked at closely and well tested of course. There's a lot of other nuances that need to be considered like session close: https://jakarta.ee/specifications/messaging/3.1/jakarta-messaging-spec-3.1#close-commit-or-rollback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
