kenliao94 commented on PR #1364:
URL: https://github.com/apache/activemq/pull/1364#issuecomment-2533379072
Thanks for the feedback @cshannon, @tabish121 and @mattrpav . So I didn't
exactly copied and pasted the AsyncCallback code, I did a few manual testing to
make sure the ordering is honor. I will see how I can test it more
comprehensively in the unit test. One challenge I had with unit testing is it
doesn't simulate delayed in Ack. I built a hacked broker to simulate ack
delayed for certain messages (if the message content contains a secret command)
and it did honor the ordering. I will make sure I add more testcases and
present it here.
Like I described in the commit description, the broker will not send out
acknowledge of the send request out of order. It can dispatch to the consumer
in different order due to message priority, but for same destination, the order
is honored. Hence I didn't implement the logic of making sure the order is
honored on the client side. If we feel that we need to enforce it on the client
side then I can see what I can do on the client code.
Regarding session close: yes 100%. That's why I would love feedback on that
on what testcases I miss. Especially I needed to add a concurrent data
structure to block until all async sends have completed. That one I can add
unit tests coverage more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
