cortlepp commented on PR #5479: URL: https://github.com/apache/activemq-artemis/pull/5479#issuecomment-2621580070
Thanks for the feedback! I wasn't aware of how this transformation was done in the other modules. As far as I can tell using the transformer plugin worked, with two exceptions. - the `javax.enterprise.inject.spi.Extension` file was just copied to the resources folder and not renamed to `jakarta.enterprise.inject.spi.Extension`. I added this file manually, thus both files are now in the resources of artemis-cdi-jakarta-client, which should not be problematic (I think). - the `isNullable()` method was removed from `Bean` in Jakarta ee9+, so we cannot override after transforming the source. I removed the `@Override` (from artemis-cdi-client), while it is unfortunate that we can't do this in a prettier way I also don't think this is a serious problem. I have never worked with this transformer plugin before though, so it would be great if someone could take another look, maybe there is a better solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
