gemmellr commented on PR #5479: URL: https://github.com/apache/activemq-artemis/pull/5479#issuecomment-2627852756
The new module should probably be named `artemis-jakarta-cdi-client`, given the convention of all the other similar such modules. The new module should be added to the bom. This change needs a Jira raised: https://issues.apache.org/jira/browse/ARTEMIS which should then be referenced in the PR title (see most other PRs except dependabot's). The commits should be squashed, and the Jira referenced in the commit message (see existing [commit history](https://github.com/apache/activemq-artemis/commits/main/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
