gemmellr commented on code in PR #5479: URL: https://github.com/apache/activemq-artemis/pull/5479#discussion_r1941075268
########## artemis-jakarta-cdi-client/pom.xml: ########## @@ -0,0 +1,227 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-pom</artifactId> + <version>2.40.0-SNAPSHOT</version> + <relativePath>../artemis-pom/pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>artemis-jakarta-cdi-client</artifactId> + <name>ActiveMQ Artemis Jakarta CDI Integration</name> + + <properties> + <jakarta.inject-api.version>${jakarta.inject-api.version.alt}</jakarta.inject-api.version> + <jakarta.annotation-api.version>${jakarta.annotation-api.version.alt}</jakarta.annotation-api.version> + <jakarta.enterprise.cdi-api.version>${jakarta.enterprise.cdi-api.version.alt}</jakarta.enterprise.cdi-api.version> + <jakarta.jms-api.version>${jakarta.jms-api.version.alt}</jakarta.jms-api.version> + <jakarta.transaction-api.version>${jakarta.transaction-api.version.alt}</jakarta.transaction-api.version> + <jakarta.ejb-api.version>${jakarta.ejb-api.version.alt}</jakarta.ejb-api.version> + <weld.version>${weld.version.alt}</weld.version> + <arquillian-weld-embedded.version>${arquillian-weld-embedded.version.alt}</arquillian-weld-embedded.version> + <owb.version>${owb.version.alt}</owb.version> + </properties> + + <dependencies> + <!-- logging --> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-log-annotation-processor</artifactId> + <version>${project.version}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.logging.log4j</groupId> + <artifactId>log4j-slf4j2-impl</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-core-client</artifactId> + </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-jakarta-client</artifactId> + </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-jakarta-server</artifactId> + </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-commons</artifactId> + </dependency> + <dependency> + <groupId>jakarta.inject</groupId> + <artifactId>jakarta.inject-api</artifactId> + </dependency> + <dependency> + <groupId>jakarta.annotation</groupId> + <artifactId>jakarta.annotation-api</artifactId> + </dependency> + <dependency> + <groupId>jakarta.enterprise</groupId> + <artifactId>jakarta.enterprise.cdi-api</artifactId> + </dependency> + <dependency> + <groupId>org.jboss.arquillian.junit</groupId> + <artifactId>arquillian-junit-core</artifactId> + </dependency> + <dependency> + <groupId>org.junit.vintage</groupId> + <artifactId>junit-vintage-engine</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>jakarta.jms</groupId> + <artifactId>jakarta.jms-api</artifactId> + </dependency> + <dependency> + <groupId>org.jboss.shrinkwrap</groupId> + <artifactId>shrinkwrap-api</artifactId> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.jboss.arquillian.junit</groupId> + <artifactId>arquillian-junit-container</artifactId> + </dependency> + <dependency> + <groupId>org.jboss.arquillian.container</groupId> + <artifactId>arquillian-container-test-api</artifactId> + <version>${arquillian.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-unit-test-support</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <configuration> + <forkCount>1</forkCount> + <reuseForks>false</reuseForks> + <argLine>--add-opens java.base/java.lang=ALL-UNNAMED ${activemq-surefire-argline}</argLine> + </configuration> + </plugin> + <plugin> + <groupId>org.wildfly.extras.batavia</groupId> + <artifactId>transformer-tools-mvn</artifactId> + <executions> + <execution> + <id>transform-sources</id> + <phase>generate-sources</phase> + <goals> + <goal>transform-sources</goal> + </goals> + <configuration> + <source-project>${project.basedir}/../artemis-cdi-client</source-project> + </configuration> + </execution> + </executions> + <dependencies> + <dependency> + <groupId>org.wildfly.extras.batavia</groupId> + <artifactId>transformer-impl-eclipse</artifactId> + <version>${version.batavia}</version> + </dependency> + </dependencies> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-clean-plugin</artifactId> + <executions> + <execution> + <id>remove-old-services-file</id> + <phase>generate-sources</phase> + <goals> + <goal>clean</goal> + </goals> + <configuration> + <filesets> + <fileset> + <directory>${project.build.directory}/generated-resources/transformed/META-INF/services/</directory> + </fileset> + </filesets> + <excludeDefaultDirectories>true</excludeDefaultDirectories> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> + + <profiles> + <profile> + <id>Weld</id> + <activation> + <activeByDefault>true</activeByDefault> + </activation> + <dependencies> + <dependency> + <groupId>org.jboss.weld.se</groupId> + <artifactId>weld-se-core</artifactId> + </dependency> + <dependency> + <groupId>org.jboss.arquillian.container</groupId> + <artifactId>arquillian-weld-embedded</artifactId> + </dependency> + <dependency> + <groupId>jakarta.ejb</groupId> + <artifactId>jakarta.ejb-api</artifactId> + </dependency> Review Comment: This ejb-api dependency listing wasn't part of the original `artemis-cdi-client` modules explicit dependencies. Though I see it used to be brought in transitively by the older cdi-api dep, but isnt anymore by the newer cdi-api version. However that cdi-api dep was always a _provided_ scope dep for `artemis-cdi-client` , meaning using applications never got it or the ejb-api via the module, whereas this ejb-api listing actually results in a _compile_ scope dependency for it meaning usages of `artemis-jakarta-cdi-client` now would see the dep. Rather than changing it to _provided_, I tried just deleting it since I see the arquillian-weld bits already bring it in themselves transitively at test scope, and as expected that meant the tests still worked fine. So, can this just be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
