gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1935617844
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncJournalTest.java:
##########
@@ -154,14 +154,9 @@ public void testReserveFileIdValuesOnBackup() throws
Exception {
assertEquals(size, backupMsgJournal.getFileSize(), "file sizes must be
the same");
Set<Pair<Long, Integer>> backupIds = getFileIds(backupMsgJournal);
-
- int total = 0;
for (Pair<Long, Integer> pair : primaryIds) {
- total += pair.getB();
Review Comment:
That further change, to remove the loops, then just leaves both of the
collections being looped over as unused themselves.
The test is called testReserveFileIdValuesOnBackup, and the collections are
seemingly about the Ids. If its not using them then it doesnt seem like its
actually testing what it meant to. If these bits are actually removed, its not
clear the test shouldnt just be deleted instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
