gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1935592106
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java:
##########
@@ -2715,13 +2715,13 @@ public void testListConnectionsAsJSON() throws
Exception {
assertNotNull(first);
assertNotNull(second);
- assertTrue(first.getString("connectionID").length() > 0);
- assertTrue(first.getString("clientAddress").length() > 0);
+ assertTrue(!first.getString("connectionID").isEmpty());
+ assertTrue(!first.getString("clientAddress").isEmpty());
Review Comment:
I think it should actually use assertFalse(foo.isEmpty()) rather than
introduce all these assertTrue( !foo.isEmpty()), or else perhaps just leave it
the way it was.
Applies here and lots below in this class, along with various other test
classes (a couple were updated to flip the assert rather than adding negations)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
