jbertram commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934614055
##########
artemis-log-annotation-processor/tests/src/test/java/org/apache/activemq/artemis/logs/annotation/processor/LogAnnotationProcessorTest.java:
##########
@@ -43,59 +43,59 @@ public class LogAnnotationProcessorTest {
@Test
@Resource("org/apache/activemq/artemis/logs/annotation/processor/cases/LAPTCase1_InvalidIDForRegex.java")
public void testIDInvalidForGivenRegex(Results results) {
- final String expectedMessage =
"org.apache.activemq.artemis.logs.annotation.processor.cases.LAPTCase1_InvalidIDForRegex:
"
- + "Code 100 does not match regular
expression specified on the LogBundle: [0-9]{1}";
-
- doCheckFailureErrorMessageTestImpl(results, expectedMessage);
+ doCheckFailureErrorMessageTestImpl(results, """
+
org.apache.activemq.artemis.logs.annotation.processor.cases.LAPTCase1_InvalidIDForRegex:
\
+ Code 100 does not match regular expression specified on the
LogBundle: [0-9]{1}\
+ """);
Review Comment:
That's fair.
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/logger/ActiveMQAMQPProtocolLogger.java:
##########
@@ -32,19 +32,25 @@ public interface ActiveMQAMQPProtocolLogger {
@LogMessage(id = 111000, value = "Scheduled task can't be removed from
scheduledPool.", level = LogMessage.Level.WARN)
void cantRemovingScheduledTask();
- @LogMessage(id = 111001, value =
"\n*******************************************************************************************************************************"
+
- "\nCould not re-establish AMQP Server Connection {} on {} after {}
retries" +
-
"\n*******************************************************************************************************************************\n",
level = LogMessage.Level.WARN)
+ @LogMessage(id = 111001, value = """
+
*******************************************************************************************************************************
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
