jbertram commented on code in PR #5487:
URL: https://github.com/apache/activemq-artemis/pull/5487#discussion_r1952034855
##########
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
##########
@@ -3053,42 +3053,21 @@ private static boolean isContainsBody(final byte
recordType) {
private static int getRecordSize(final byte recordType, final int
journalVersion) {
// The record size (without the variable portion)
- int recordSize = 0;
- switch (recordType) {
- case ADD_RECORD:
- case EVENT_RECORD:
- recordSize = JournalImpl.SIZE_ADD_RECORD;
- break;
- case UPDATE_RECORD:
- recordSize = JournalImpl.SIZE_ADD_RECORD;
- break;
- case ADD_RECORD_TX:
- recordSize = JournalImpl.SIZE_ADD_RECORD_TX;
- break;
- case UPDATE_RECORD_TX:
- recordSize = JournalImpl.SIZE_ADD_RECORD_TX;
- break;
- case DELETE_RECORD:
- recordSize = JournalImpl.SIZE_DELETE_RECORD;
- break;
- case DELETE_RECORD_TX:
- recordSize = JournalImpl.SIZE_DELETE_RECORD_TX;
- break;
- case PREPARE_RECORD:
- recordSize = JournalImpl.SIZE_PREPARE_RECORD;
- break;
- case COMMIT_RECORD:
- recordSize = JournalImpl.SIZE_COMMIT_RECORD;
- break;
- case ROLLBACK_RECORD:
- recordSize = JournalImpl.SIZE_ROLLBACK_RECORD;
- break;
- default:
+ int recordSize = switch (recordType) {
+ case ADD_RECORD, EVENT_RECORD -> JournalImpl.SIZE_ADD_RECORD;
+ case UPDATE_RECORD -> JournalImpl.SIZE_ADD_RECORD;
Review Comment:
Fixed.
##########
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
##########
@@ -3053,42 +3053,21 @@ private static boolean isContainsBody(final byte
recordType) {
private static int getRecordSize(final byte recordType, final int
journalVersion) {
// The record size (without the variable portion)
- int recordSize = 0;
- switch (recordType) {
- case ADD_RECORD:
- case EVENT_RECORD:
- recordSize = JournalImpl.SIZE_ADD_RECORD;
- break;
- case UPDATE_RECORD:
- recordSize = JournalImpl.SIZE_ADD_RECORD;
- break;
- case ADD_RECORD_TX:
- recordSize = JournalImpl.SIZE_ADD_RECORD_TX;
- break;
- case UPDATE_RECORD_TX:
- recordSize = JournalImpl.SIZE_ADD_RECORD_TX;
- break;
- case DELETE_RECORD:
- recordSize = JournalImpl.SIZE_DELETE_RECORD;
- break;
- case DELETE_RECORD_TX:
- recordSize = JournalImpl.SIZE_DELETE_RECORD_TX;
- break;
- case PREPARE_RECORD:
- recordSize = JournalImpl.SIZE_PREPARE_RECORD;
- break;
- case COMMIT_RECORD:
- recordSize = JournalImpl.SIZE_COMMIT_RECORD;
- break;
- case ROLLBACK_RECORD:
- recordSize = JournalImpl.SIZE_ROLLBACK_RECORD;
- break;
- default:
+ int recordSize = switch (recordType) {
+ case ADD_RECORD, EVENT_RECORD -> JournalImpl.SIZE_ADD_RECORD;
+ case UPDATE_RECORD -> JournalImpl.SIZE_ADD_RECORD;
+ case ADD_RECORD_TX -> JournalImpl.SIZE_ADD_RECORD_TX;
+ case UPDATE_RECORD_TX -> JournalImpl.SIZE_ADD_RECORD_TX;
Review Comment:
Fixed.
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AMQPMessageSupport.java:
##########
@@ -415,11 +415,11 @@ public static String destination(RoutingType
destinationType, String address) {
destinationType = RoutingType.ANYCAST;
}
- switch (destinationType) {
- case ANYCAST: prefix = QUEUE_QUALIFIED_PREFIX; break;
- case MULTICAST: prefix = TOPIC_QUALIFIED_PREFIX; break;
- default: prefix = QUEUE_QUALIFIED_PREFIX; break;
- }
+ prefix = switch (destinationType) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
