jbertram commented on code in PR #5487:
URL: https://github.com/apache/activemq-artemis/pull/5487#discussion_r1952035125
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java:
##########
@@ -737,8 +732,7 @@ private void
sendLargeFile(AbstractJournalStorageManager.JournalContent content,
final ReusableLatch flushed = new ReusableLatch(1);
try {
- try (FileInputStream fis = new FileInputStream(file.getJavaFile());
- FileChannel channel = fis.getChannel()) {
+ try (FileInputStream fis = new FileInputStream(file.getJavaFile());
FileChannel channel = fis.getChannel()) {
Review Comment:
Fixed.
##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
##########
@@ -549,21 +549,15 @@ protected void setupDestination() throws Exception {
throw ActiveMQRABundle.BUNDLE.noDestinationName();
}
+ // If there is no binding on naming, we will just create a new
instance
String calculatedDestinationName =
destinationName.substring(destinationName.lastIndexOf('/') + 1);
if (isTopic) {
- calculatedDestinationName =
getTopicWithPrefix(calculatedDestinationName);
- } else if (!isTopic) {
- calculatedDestinationName =
getQueueWithPrefix(calculatedDestinationName);
+ destination =
ActiveMQDestination.createTopic(getTopicWithPrefix(calculatedDestinationName));
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
