jbertram commented on code in PR #5487:
URL: https://github.com/apache/activemq-artemis/pull/5487#discussion_r1952903558
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/RandomUtil.java:
##########
@@ -51,7 +53,7 @@ public static Random getRandom() {
public static String randomAlphaNumericString(int length) {
StringBuilder result = new StringBuilder(length);
for (int i = 0; i < length; i++) {
- result.append(randomBase.charAt(randomInterval(0,
randomBase.length())));
+ result.append(randomBase.charAt(random.nextInt(randomBaseLength)));
Review Comment:
Use `randomChar()` instead? i.e.:
```
result.append(randomChar());
```
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/RandomUtil.java:
##########
@@ -51,7 +53,7 @@ public static Random getRandom() {
public static String randomAlphaNumericString(int length) {
StringBuilder result = new StringBuilder(length);
for (int i = 0; i < length; i++) {
- result.append(randomBase.charAt(randomInterval(0,
randomBase.length())));
+ result.append(randomBase.charAt(random.nextInt(randomBaseLength)));
Review Comment:
Use `randomChar()` instead? i.e.:
```java
result.append(randomChar());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
