grgrzybek commented on code in PR #76:
URL: 
https://github.com/apache/activemq-artemis-console/pull/76#discussion_r2066327875


##########
artemis-console-extension/artemis-extension/app/package.json:
##########
@@ -0,0 +1,67 @@
+{

Review Comment:
   You project Java experience to JavaScript ;)
   I found that if a dependency is present in "child" package.json (child 
_workspace_) and it's not in the parent, `yarn` creates separate 
`node_modules/` base and webpack gets confused...
   Ideally we should have _parent_ package.json, but it's not working like this 
with yarn/npm workspaces.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to