grgrzybek commented on code in PR #76:
URL:
https://github.com/apache/activemq-artemis-console/pull/76#discussion_r2068259098
##########
artemis-console-extension/pom.xml:
##########
@@ -87,14 +87,21 @@
<configuration>
<filesets>
<fileset>
-
<directory>${basedir}/${extension.path}/build</directory>
+
<directory>${basedir}/${extension.path}/app/build</directory>
<includes>
<include>**/*</include>
</includes>
<followSymlinks>false</followSymlinks>
</fileset>
<fileset>
-
<directory>${basedir}/artemis-extension/node_modules</directory>
+
<directory>${basedir}/${extension.path}/packages/artemis-console-plugin/dist</directory>
Review Comment:
the "library" (bundled using `tsup`) is consumend in the "app" (bundled
using `webpack`), so should be treated as _intermediate_ artifact and is used
with support from yarn workspaces here:
https://github.com/apache/activemq-artemis-console/blob/f1e57e1a739aefede54ca376083cd0706255585d/artemis-console-extension/artemis-extension/app/package.json#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
