gemmellr commented on code in PR #76:
URL:
https://github.com/apache/activemq-artemis-console/pull/76#discussion_r2066881831
##########
artemis-console-extension/artemis-extension/.yarn/releases/LICENSE-yarn.txt:
##########
Review Comment:
This file is/was referenced from the main root LICENSE file, and the
source-release assembly.
Either it shouldn't be getting removed, if the license hasn't changed to
ASLv2, or if it has changed then the root LICENSE file and source-release
assembly details
(artemis-console-distribution/src/main/assembly/source-assembly.xml) should
also be updated accordingly.
##########
artemis-console-extension/pom.xml:
##########
@@ -87,14 +87,21 @@
<configuration>
<filesets>
<fileset>
-
<directory>${basedir}/${extension.path}/build</directory>
+
<directory>${basedir}/${extension.path}/app/build</directory>
<includes>
<include>**/*</include>
</includes>
<followSymlinks>false</followSymlinks>
</fileset>
<fileset>
-
<directory>${basedir}/artemis-extension/node_modules</directory>
+
<directory>${basedir}/${extension.path}/packages/artemis-console-plugin/dist</directory>
Review Comment:
...or new ones have been added.
##########
artemis-console-extension/pom.xml:
##########
@@ -87,14 +87,21 @@
<configuration>
<filesets>
<fileset>
-
<directory>${basedir}/${extension.path}/build</directory>
+
<directory>${basedir}/${extension.path}/app/build</directory>
Review Comment:
Pretty sure there were entries in the source release assembly to avoid
including the original build dir, so the assembly probably needs updated if
these have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
