cshannon opened a new pull request, #1567: URL: https://github.com/apache/activemq/pull/1567
This cleanups the MessageDatabase and KahaDBStore classes. This commit includes the following: * Fixes the scope of several methods and types. For example, there were many cases where protected methods were referencing types that were package scope. * Simplified the code by replacing anonymous methods with lambdas * removed unused methods and parameters * removed unnecessary casts * cleaned up the use of generics where types could be inferred * Replaced the ReentrantReadWriteLock that was used for indexLock with ReentrantLock becuase only the write lock was ever being used (the page file doesn't support concurrent reads right now). This should provide a small performance/memory improvement and simplifies the code a bit. * removed unnecessary null initializations * cleaned up logging to remove string concatenation and instead use parameters * removed method overrides that are the same as the parent or just call the super method * removed unused checked exceptions from method's throws * marked inner classes as static when possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
