mattrpav commented on code in PR #1567:
URL: https://github.com/apache/activemq/pull/1567#discussion_r2635105024
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBStore.java:
##########
@@ -109,8 +106,8 @@ public class KahaDBStore extends MessageDatabase implements
PersistenceAdapter,
protected ExecutorService queueExecutor;
protected ExecutorService topicExecutor;
- protected final List<Map<AsyncJobKey, StoreTask>> asyncQueueMaps = new
LinkedList<>();
- protected final List<Map<AsyncJobKey, StoreTask>> asyncTopicMaps = new
LinkedList<>();
+ final List<Map<AsyncJobKey, StoreTask>> asyncQueueMaps = new
LinkedList<>();
Review Comment:
What is the thought on narrowing the scope here? What if someone extended
the class but it is not in the same package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
